I noticed there were no thruster reaction torques included in the various frame definitions in AP_Motors6DOF.cpp in yaw.
Was this intentional? Were they measured and found to be insignificant compared the thruster moments? I’m confused since some quad copters rely solely on motor reaction torques to control yaw.
It was omitted not intentionally, but because there has been a lack of a need to implement it. The control system is not based on a physical model, it just reacts to feedback. This allows the autopilot to be put in vehicles across the entire spectrum of dynamic characteristics, and then the PID controllers can be tuned to suit the vehicle.
The ROVs that ArduSub has been designed for have direct control over yaw, if not all 6DOF, so the vehicle produces yaw torque in a different manner than multirotors. It is not strictly necessary to have counter-rotating props in an ROV like it is in a multirotor. In ArduSub, the counter-rotating pair suggestions for each frame were designed to minimize the net torques on the vehicle during normal operation; whatever net torque does arise does not have a significantly noticeable impact on the vehicle after the autopilot has dealt with it.
Only the torque from the vertical thrusters would cause the ROV to yaw, and if we tried to do that, it would cause the vehicle to roll and become unstable. The vectored thrusters are configured to cancel torque between thrusters most of the time.